Browse categories/top100

[mikkelam]

How about adding the ability to browse the top 100 torrents? I personally use that a lot

[defektive]

it would be nice to allow more advanced filtering.

Such as top music torrents or only search audio books.

[defektive]

@vikstrous how would you feel if I switched the config file to json?

[defektive]

@mikkelam I just pushed some code up to a new branch. You will need to run the install.sh script again. Let me know if you have any problems or questions. I need to fix the argument parser before I put this on master. If there is anything that can be improved, please let me know.

[vikstrous]

As hacky as it would be, I would prefer to keep the mapping from category name to id in the same file. That way I wouldn't have to make the packaging and deployment any more complex. Maybe one day someone can make this into a real package for a few distros ;)

TLDR: I would prefer it if you inline that json as a dictionary for now.

I don't think I see the difference between top 100 and browse sorted by seeders. I guess top 100 are more recent torrents?

What do you think about this interface:

# browse the most popular torrents in any category with the highest number of seeders
pirate-get
# search for abc in any category
pirate-get "abc"
# search for abc in a specific category
pirate-get "abc" -c Audio
# browse in a category
pirate-get -c Audio
# browse top 100 in a category
pirate-get -c Audio -T
# browse top 100
pirate-get -T

I guess this allows for

pirate-get "abc" -T

and that doesn't make any sense, but we can just throw an error in that case.

[defektive]

I like the changes in the interface. I wonder if we should go even more apt-get-like. Eg: pirate-get search "term" pirate-get browse

[mikkelam]

@defektive Lovely! good job

[defektive]

@mikkelam Glad to hear! Don't get too attached to the usage yet, we may be changing the params.

[vikstrous]

Hmm... Your proposal allows for more features to be added later on and my proposal just optimizes for the current use cases. I guess the middle road is something like pacman where the commands look like pacman -Syu which is short, extensible and absolutely cryptic.

I propose we follow Google's way of making decisions like this: if you feel strongly enough about it to volunteer to write the code, then it will happen the way you want it.

I don't feel strongly enough about it to write the code, so I'll let you, @defektive, decide.

[defektive]

After think about it for a while, I like your first idea better. After looking into it more it seems -T is irrelevant, so I am going to remove it.

just to be clear, this is what i am going to implement

# browse top 100
pirate-get

# browse top 100 in Music
pirate-get -c "Audio/Music"

# search everything
pirate-get "Silicon Valley"

# search only TV Shows
pirate-get -c "Video/TV Shows" "silicon valley"

I also want to make it so you can use the category id rather than having to type out "Videos/TV Shows"

[vikstrous]

Sounds good :)