viktorgullmark / exilence-next

Desktop application that helps you summarize your wealth in Path of Exile
649 stars 124 forks source link

Calculate net worth delta between snapshots using same price data #833

Open CxyzOk opened 2 years ago

CxyzOk commented 2 years ago

Problem

The price of items can vary significantly between snapshots (usually due to price fixing, but also streamer effect etc.), which might play too significant part in total net worth calculation.

For instance let's assume i initially have 20 'The doctor' cards, each worth 10ex at the time i fetch 1st snapshot. Now, after 2 hours of farming during which i looted 200c worth of items, and fetch another snapshot, I would expect +200c net worth to be displayed, however if in the meantime The doctor card got price fixed at 9.5ex, suddenly net worth would show at around [200c - 5ex], so a negative number, cause The Doctor card value dropped between shapshots.

While I understand that this can be useful in some rare situations, it makes difficult to track your progress if you have a lot of high value high liquidity items in your stash tabs.

Yes, there are workarounds (like using only specific tabs for exilence to track etc), however this is generic problem anyway. Apparently it seems like delta net worth is calculated as: Delta Net Worth = Net Worth(current snapshot) - Net Worth(previous snapshot) which is the main reason why the net worth can be completely out of orbit

Solution

I think solution is to calculate Net Worth Delta as a Sum of Item Latest Price * item count change. IMO it should be the default behaviour, but in case current default behaviour is useful for large number of players, we can add Configuration Option to control the behaviour.