search

viktorgullmark / exilence

DEPRECATED Tool for Path of Exile that calculates net worth and tracks gear, maps and other statistics for you and your group
GNU General Public License v3.0
186 stars 26 forks source link

Starting app with a private profile #20

Closed aggixx closed 5 years ago

aggixx commented 6 years ago

I have my characters tab set to private, and every time I launch the app it tells me to select a character from the list, but the list is empty because it can't pull it from my profile (even though it has my session ID). If it already has my session ID shouldn't it be able to sort this out without me public'ing my profile every time I start the program?

viktorgullmark commented 6 years ago

Unfortunately we cannot get all the information we need without you setting your profile to public. One such thing is the character-list, since we use the same API as the website(pathofexile.com).

Sorry about any inconvenience regarding this!

Closing this

aggixx commented 6 years ago

What about caching the character list once its pulled the first time? That way you'd only need to set to public if you wanted to select a new character. Or are there other critical features that require a public profile that make supporting private profiles at all a bad idea?

viktorgullmark commented 6 years ago

Actually a good idea after thinking more about this. The whole fetching-process should be possible with only your sessionId, without exposing your profile. I'll have a closer look at the endpoints available for this and see what we can do to make this a possibility.

Thanks again, and I'll keep you posted

viktorgullmark commented 5 years ago

This is implemented now and will be published with our next release (0.6.2). Let me know if you experience any problems with this!

https://github.com/viktorgullmark/exile-party/commit/9a4e246128c8da3ca6ebc9605b1cf6e777b2f65a

aggixx commented 5 years ago

Awesome, thanks for your hard work.

viktorgullmark commented 5 years ago

Np! Hopefully it works out for you