viktorlarsson / vue-tiny-slider

Vanilla javascript slider for all purposes created by ganlanyuan in Vue.
MIT License
135 stars 50 forks source link

[Feature Request] Add manual control over how slider styles are destroyed #62

Open AndrewBogdanovTSS opened 4 years ago

AndrewBogdanovTSS commented 4 years ago

Right now there is an issue with styles being removed from the slider on destroy which leads to visual mess and jumpiness of items when navigating from one vue route to another. Ideally there should be an option to control styles deletion in the destroy process. What is needed: slider.destroy(cleanStyles); where cleanStyles - boolean - (true by default) Set it to false to keep styles on the instance during destroy process

bennettfrazier commented 4 years ago

@AndrewBogdanovTSS ^ What have you done to account for this? I am running into the same issue. Basically my slides stack their height with the background color after route change is initialized.

AndrewBogdanovTSS commented 4 years ago

There's nothing that can be done to account for this except the way I requested it. It's a built in functionality that should be implemented within a lib, not somewhere outside. It may also be related to the core tiny slider lib, not the Vue wrapper, or maybe both