search

viktorlarsson / vue-tiny-slider

Vanilla javascript slider for all purposes created by ganlanyuan in Vue.
MIT License
135 stars 51 forks source link

Incorrect type check for controlsContainer prop #9

Closed chrisjantzen closed 6 years ago

chrisjantzen commented 6 years ago

The controlsContainer throws an vue error when it is set to a String:

Invalid prop: type check failed for prop "controlsContainer". Expected Boolean, Node, got String.

Yet the documentation clearly states that it can take a Node, String or a Boolean.

The code I am using:

`<vue-tiny-slider class="tiny-slider" :items="1" :mouse-drag="true" :fixed-width="380" :controls-container="#slider-controls-${this.controlsId}`" :responsive="sliderReponsiveSettings">

``

chrisjantzen commented 6 years ago

I have put in a pull request with a fix.

10