search

viktorradnai / flightgear-ask21

ASK21 glider model for Flightgear
5 stars 6 forks source link

Reflection type=2 is obsolete #109

Closed HHS81 closed 6 years ago

HHS81 commented 7 years ago

the used reflection-type=2 (2) is obsolete, as the underlying issue is fixed now in FlightGear 2017.2.0.

viktorradnai commented 7 years ago

I'm aware of this and the parameter will be removed when FG 2017.2 comes out.

On 16 Mar 2017 5:18 p.m., "HHS81" notifications@github.com wrote:

the used reflection-type=2 (2) is obsolete, as the underlying issue is fixed now in FlightGear 2017.2.0.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viktorradnai/flightgear-ask21/issues/109, or mute the thread https://github.com/notifications/unsubscribe-auth/AEhMgtGf4zycREy-5_5z8M8GjFsuiih_ks5rmW71gaJpZM4Mfnjk .

ghost commented 7 years ago

Does this mean it won't work in 2017.1 after this?

Gesendet mit der Telekom Mail App http://www.t-online.de/service/redir/email_app_android_sendmail_footer.htm

--- Original-Nachricht --- Von: Viktor Radnai Betreff: Re: [viktorradnai/flightgear-ask21] Reflection type=2 is obsolete (#109) Datum: 16.03.2017, 19:09 Uhr An: viktorradnai/flightgear-ask21 Cc: Subscribed

I'm aware of this and the parameter will be removed when FG 2017.2 comes out.

On 16 Mar 2017 5:18 p.m., "HHS81" notifications@github.com wrote:

the used reflection-type=2 (2) is obsolete, as the underlying issue is fixed now in FlightGear 2017.2.0.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viktorradnai/flightgear-ask21/issues/109, or mute the thread

https://github.com/notifications/unsubscribe-auth/AEhMgtGf4zycREy-5_5z8M8GjFsuiih_ks5rmW71gaJpZM4Mfnjk .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viktorradnai/flightgear-ask21/issues/109#issuecomment-287144430 , or mute the thread https://github.com/notifications/unsubscribe-auth/ALtQ-F38nsIWvGrZ0JWGcoU2QVzxJNQbks5rmXrUgaJpZM4Mfnjk .

viktorradnai commented 7 years ago

If we remove it now, the model will look too dark under most lighting conditions.

HHS81 commented 7 years ago

With 2017.1.0 and older the reflection will look darker (grey-tint-issue), that's why there was refl-type=2 to select. This issue is now fixed in FGData, refl-type=2 obsolete and will be available with the next stable version. Just look Eriks PC-9M pictures in the forum how it looks much better now

ghost commented 7 years ago

so it will Look better if we remove this part after 2017.2 is released than if it's kept? because if not I'll rather go with Reverse compatibility

Gesendet mit der Telekom Mail App http://www.t-online.de/service/redir/email_app_android_sendmail_footer.htm

--- Original-Nachricht --- Von: HHS81 Betreff: Re: [viktorradnai/flightgear-ask21] Reflection type=2 is obsolete (#109) Datum: 16.03.2017, 19:58 Uhr An: viktorradnai/flightgear-ask21 Cc: D-ECHO, Comment

With 2017.1.0 and older the reflection will look darker (grey-tint-issue), that's why there was refl-type=2 to select. This issue is now fixed in FGData, refl-type=2 obsolete and will be available with the next stable version. Just look Eriks PC-9M pictures in the forum how it looks much better now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/viktorradnai/flightgear-ask21/issues/109#issuecomment-287158160 , or mute the thread https://github.com/notifications/unsubscribe-auth/ALtQ-H9kZGC6MihPVYiBrYlNOWdcdLmeks5rmYZbgaJpZM4Mfnjk .

HHS81 commented 7 years ago

@D-ECHO refl-type=2 is currently kept. But even if we remove it, it will automatically fall back to type=1.

Refl-Type=2: fgfs-screen-003 fgfs-screen-004

Refl-Type=1 New: fgfs-screen-008 fgfs-screen-009

ghost commented 6 years ago

@HHS81 @viktorradnai Even when using 2017.4.0, the aircraft looks a lot better with reflection-type=2, so IMO we should keep it, even if it will sometime in the future not be needed anymore, still for those with older version (somehow including current version) it should be kept as it leads if I unterstand correctly to now advantages to remove it. fgfs-screen-667 fgfs-screen-668

HHS81 commented 6 years ago

@D-ECHO As the original author of Type=2 (Thorsten was so nice by adding this) I can still repeat that Type=2 is physically wrong. Even when Throsten decides to skip Type=2 some day, it will automatically fall back to Type=1. Looking at the image showing Type=1 I can see that it is not correct configured and make use of unrealistic features.

HHS81 commented 6 years ago

@viktorradnai @D-ECHO You might wanna check this: https://github.com/viktorradnai/flightgear-ask21/pull/154

ghost commented 6 years ago

@HHS81, looks really good thank you, will evaluate today or tomorrow and merge, thank you again!

viktorradnai commented 6 years ago

@HHS81 Thanks for this, much appreciated. Please see my comment to the MR.