viktorradnai / flightgear-ask21

ASK21 glider model for Flightgear
5 stars 6 forks source link

Cockpit view inaccuracies #119

Open viktorradnai opened 7 years ago

viktorradnai commented 7 years ago

There are a few things that are wrong with the cockpit still. I'll make a list here, feel free to break them out into separate issues. The first two are mentioned in #79 and there are a couple of pictures too.

  1. ~The instructor's panel has the wrong shape~ done
  2. The front seat has the wrong shape when viewed from the instructor's seat better but not perfect
  3. ~The floor should be flat in the rear footwell but curved in front footwell. It's currently the other way around.~ done
  4. The instructor's pedals are positioned wrong, this is only fixable after addressing 2. and 3. above. partly done
  5. The stick should have a cloth surround to prevent items falling into it. This cloth is actually sewn onto the seat cushion and therefore should be the same colour material. This applies to both sticks. very difficult to do ;)
  6. ~The front stick is too far forward, it should be sticking out of the seat base.~ done
  7. ~The rear seat should also have an air vent on the right side, same as the front.~ done
  8. ~The front air vent is unfinished, there should be a butterfly valve (painted black) in the opening, it's currently white.~ done?
  9. ~The trim indicator is missing on the right side of both seats (mentioned in #99) -- also see item 15.~ done
  10. ~Both seats should have armrests near the elbow position (see the photo attached to #99)~ done
  11. ~There are some screws on both sides of both cockpits, allowing the seat base to be lifted out for maintenance.~ done
  12. The airbrake handle has a moulded rubber grip that is shaped to fit in your hand, it's not just a plain cylinder. very difficult to model ;)
  13. ~The canopy latches lack the attachment point and pushrods, also visible in #99.~ done
  14. ~The "hoop" of the cockpit that goes between the two canopy halves has a texturing error, clearly visible from the rear seat.~ done
  15. ~There should be another 3D object just below the armrest that could be textured. This should be showing through the hole for the airbrake (raw fibeglass colour, according to the picture in #99) and should be showing the trim indicator on the right.~ done

That's about everything I've found so far. I have mentioned most of these previously but most of them haven't made it into its own issue.

viktorradnai commented 7 years ago

Regarding item 15 above, the fibreglass showing through the airbrake hole is really the side of the glider, so it's also OK to texture that the same way as the front of the footwell. Whichever is easier.

gilbertohasnofb commented 7 years ago

Ok, so I can help with a couple of these (concerning textures), but I just need some clarifications:

8 I can create a texture for it, perhaps @D-ECHO could UV-map it to parts.png in the position shown in the picture below (in pink) parts

11 do you mean the these three screws here? If so, then @D-ECHO needs to create them as 3D objects and I can create textures for it (mapping them to panel.png please) untitled

14 I think I see what you mean, but this is not an error with the texture but rather with the UV-map. @D-ECHO it seems you mapped the floor of the airplane to the bottom side of the hoop.

15 do you mean this would be seen from the airbrake handle hole? @D-ECHO if you create a surface for that and UV-map it to parts.png in the position shown above (in pink), I can make a texture for it (should be the same yellow fibreglass as the front of the plane, right?)

I think all others are 3D model related only.

ghost commented 7 years ago

Wow, much to be done :laughing: But first, I'd like to tell you that I am not going to improve the current interior model any further due to significant inaccuracies in shape e.g. of the windows/doors. Instead I am going to do a new model (fuselage+interior), which will take a bit of time but I think it's really worth it :D

ghost commented 7 years ago

Btw, yesterday I've been flying the (real) ASK21 for the first time (fun fact: We also removed the main wheel fairing after running 10cm into ground and having very much dirt in it)

gilbertohasnofb commented 7 years ago

@D-ECHO It's up to you, either way (if you get to do any of these improvements done in the current model or create a new model) just let me know if you need any help with the textures.

Btw, yesterday I've been flying the (real) ASK21 for the first time

Oh, that's great! I always wanted to try soaring but never had the opportunity!

ghost commented 7 years ago

@gilbertohasnofb it would be great if you could do a texture for the trim indicator somewhere in the interior.png :D

gilbertohasnofb commented 7 years ago

@D-ECHO Ok, I will do that. Should I also add the top of the vent and the yellow fibreglass panel textures in the positions I have shown here https://github.com/viktorradnai/flightgear-ask21/issues/119#issuecomment-289433745 ?

ghost commented 7 years ago

Yep pls

gilbertohasnofb commented 7 years ago

Nearly done with these textures. This is what I got for the trim texture, and this is how it should be used:

trim

Makes sense?

gilbertohasnofb commented 7 years ago

@D-ECHO new textures are done, see:

viktorradnai commented 7 years ago

@gilbertohasnofb I mean the four silver screws here, two on each side: fb30f3a0-08f3-11e7-8f57-da6d79d73021 Two of them are just backwards from the airbrake lever, while there are another two on the opposite side. Note the line that runs next to them, along the edge of the cockpit, back to the armrests. That is the edge of the seat panel which comes out for maintenance. Those two silver screws are holding it in place (I'm sure there are more of them but they aren't so prominient).

gilbertohasnofb commented 7 years ago

@viktorradnai ah, I see, so I will add textures for these screws to parts.png and then later @D-ECHO can add the screw models.

ghost commented 7 years ago

I've already added the screw models :D waiting for the tex

ghost commented 7 years ago

If you'd like to try the new int, use branch newint :D

ghost commented 7 years ago

1,3,6,7,8,9,10,11,13,14 and 15 more or less fixed in branch newint :D

5 is difficult to fix because it's very complicated (if not impossible) to animate that cloth movement with stick

gilbertohasnofb commented 7 years ago

@D-ECHO I will add the new textures to newint then

ghost commented 7 years ago

:+1:

Am 28.03.2017 um 20:38 schrieb Gilberto Agostinho:

@D-ECHO https://github.com/D-ECHO I will add the new textures to |newint| then

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/viktorradnai/flightgear-ask21/issues/119#issuecomment-289864763, or mute the thread https://github.com/notifications/unsubscribe-auth/ALtQ-OZM7EMg6CJKd5Wjdw1057rZeUBAks5rqVO3gaJpZM4Mp7lj.

gilbertohasnofb commented 7 years ago

@D-ECHO Ok, new textures are added (please do a git pull) but there are quite a lot of issues we need to tackle. First, here are the new textures:

instructions

A is the texture for the side screws, B is for the nose, C is the back of the placard for opening the canopy and D will be explained below.

fgfs-screen-010

fgfs-screen-009

fgfs-screen-006 fgfs-screen-007 fgfs-screen-008

gilbertohasnofb commented 7 years ago

@D-ECHO one more thing, the scew on top of the panel is being cut by the registration, would it be possible to fix it?

fgfs-screen-004

viktorradnai commented 7 years ago

@D-ECHO nice work, lot of things look better. There are a bunch of things that are slightly wrong again -- you have added more detail which gives more room for errors :) Would you like me to open another issue with them or list them out here?

viktorradnai commented 7 years ago

@gilbertohasnofb I think the instrument panel needs to be rearranged to make the instruments clear of the screws. I have promised to work on this but I might not have the time until mid-next week. I'll try to do a quick fix in the meantime.

viktorradnai commented 7 years ago

@gilbertohasnofb @D-ECHO see PR #125 for the rearranged instrument panel . Feel free to suggest changes, we can even have different arrangement for different countries. For some reason, in the UK (or at least in our club) the preference is to have the altimeter below the ASI, and both of them on the left side of the panel.

gilbertohasnofb commented 7 years ago

Would you like me to open another issue with them or list them out here?

Perhaps that's the best way to go, I am fearing that a lot of the things we need to do will get lost as we are having conversations all over the place (but perhaps you guys have a better memory than me for these)

I think the instrument panel needs to be rearranged to make the instruments clear of the screws

It is merged now, so @D-ECHO can lower that top screw in the front panel

viktorradnai commented 7 years ago

@gilbertohasnofb I'd rather lower the callsign label. Or both.

I think this issue can be closed after the texturing issues have been resolved. I'll open a new one with the issues that are still outstanding.

gilbertohasnofb commented 7 years ago

@viktorradnai according to both cockpit photographies in this thread, the top screw in the pilot's panel should be considerably lower than what we got. But I agree we could lower the callsign label as well.

I think this issue can be closed after the texturing issues have been resolved. I'll open a new one with the issues that are still outstanding.

:+1:

ghost commented 7 years ago

@viktorradnai sorry for messing around in your first post but this way we can see what's done/to be done much better :D

gilbertohasnofb commented 7 years ago

If you guys create a post using:

* [ ] foo
* [ ] bar

then GitHub creates toggle boxes, which can be clicked by any collaborator (handy to keep track of things):

But editing a post to strike things that have been done is perfectly fine in my view.