search

viktorradnai / flightgear-ask21

ASK21 glider model for Flightgear
5 stars 6 forks source link

Shadows in rear cockpit #87

Open viktorradnai opened 7 years ago

viktorradnai commented 7 years ago

Looks like the shadows aren't applied to the rear cockpit interior -- or perhaps there is a shadow that should not be there. I've noticed a shadow appearing in the footwell that did not continue into the instructor's cockpit area.

fgfs-screen-263 fgfs-screen-264

ghost commented 7 years ago

-wrong cubemap is fixed but we still need a possibility for darker shading in the footwell

ghost commented 6 years ago

I think we might want to use some irradiance map here, so we can have darker shading in the footwell, but I haven't yet figured out how to do so @gilbertohasnofb do you know that by chance?

gilbertohasnofb commented 6 years ago

@D-ECHO I do not know how the irradiance map works but perhaps @wlbragg could point you in the right direction.

wlbragg commented 6 years ago

I think we might want to use some irradiance map here, so we can have darker shading in the footwell,

I'm not sure that is the issue here. You should get a darker footwell simply by using the default model interior.

wlbragg commented 6 years ago

After looking at the models, is it because the fuselage model has nothing to indicate that the footwell is in shadow. Does it not recognize the separate interior.ac as casting shadow?

wlbragg commented 6 years ago

When making the shadow map you would want the entire model assembled into one piece for one. As far as the two separate models ask21.ac and interior.ac recognizing the other has influence, I will have to download the repo and test it for myself to wrap my head around it.

ghost commented 6 years ago

Thanks @wlbragg for looking at this, but I have to admit I don't really understand what you're writing. With "shadow map" do you mean the black cubemap passed to the interior-model.eff () or the AO shadows baked onto the texture?

wlbragg commented 6 years ago

the black cubemap passed to the interior-model.eff

Yes that is the one, but that still wont get you darker recessed areas.

I just installed this and it looks reasonable to me. I didn't notice any misplaced shadows. I think it is fairly light down in the recesses because of the open top.