search

viktorradnai / flightgear-ask21

ASK21 glider model for Flightgear
5 stars 6 forks source link

Add ground shadow #92

Closed viktorradnai closed 7 years ago

viktorradnai commented 7 years ago

ALS can be used to add a ground shadow, and this would be a nice addition. I always found the lack of it very annoying.

ghost commented 7 years ago

fgfs-screen-111

gilbertohasnofb commented 7 years ago

Closed via #95

viktorradnai commented 7 years ago

@D-ECHO the shadow implementation has various severe bugs. I have seen incomplete shadows, shadows aligned wrong at low sun angles and somehow I even managed to get the shadow detached from the ground and attached to the model. Are these all Flightgear bugs, or is there anything we can do to fix them?

fgfs-screen-293 fgfs-screen-295 fgfs-screen-297 fgfs-screen-298 fgfs-screen-299 fgfs-screen-301

gilbertohasnofb commented 7 years ago

The shadow seems to work well at noon but looks strange at other times (it seems to rotate). But about your last picture, Viktor, did you by any chance reset the simulator or used the position in the air option? That used to make strange things with the shadow with the c172p, and that was due to a known FG problem (resetting and position aircraft in the air are buggy)

viktorradnai commented 7 years ago

Indeed, the first problem is the shadow rotating -- looks like the orientation code has an extra, unwanted rotation in it. The second problem was caused by a reset. Looks like we need to put this off until these bugs are fixed, don't we?

On 14 March 2017 at 22:21, Gilberto Agostinho notifications@github.com wrote:

The shadow seems to work well at noon but looks strange at other times (it seems to rotate). But about your last picture, Viktor, did you by any chance reset the simulator or used the position in the air option? That used to make strange things with the shadow with the c172p, and that was due to a known FG problem (resetting and position aircraft in the air are buggy)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/viktorradnai/flightgear-ask21/issues/92#issuecomment-286579724, or mute the thread https://github.com/notifications/unsubscribe-auth/AEhMgvpM7_pMJceAJL6HCylhN32TyLvtks5rlxLygaJpZM4McGBP .

-- My other sig is hilarious