viktorradnai / flightgear-ask21

ASK21 glider model for Flightgear
5 stars 6 forks source link

Make instrument light selectable #95

Closed ghost closed 7 years ago

gilbertohasnofb commented 7 years ago

@D-ECHO this seems a bit messy, why are you having textures modifications in this PR (e.g. sc7-top.png or blank.png?) This might conflict with #97

gilbertohasnofb commented 7 years ago

I just realized that you made the instrument vario/ilec-sc7 local, and so did I in that other PR. Perhaps it would be better to merge this first as I have modifications to the textures as well.

gilbertohasnofb commented 7 years ago

I just tested this PR and everything seems to work well, but just a couple of things:

ghost commented 7 years ago

it's now off by default plus ground shadow is added!

gilbertohasnofb commented 7 years ago

Great, let me try again. Then I will merge this and solve any conflicts with the other PR I pushed

gilbertohasnofb commented 7 years ago

@D-ECHO looking good, nearly there. But it looks to me that the shadow is pitch black, shouldn't it have a bit more of transparency like in the c172p? See:

fgfs-screen-002

gilbertohasnofb commented 7 years ago

Also, I would not make the canopy of the shadow half transparent, as it looks very strange from most angles (for instance in the image above, the glass wouldn't influence the shadow but rather the bottom of the plane!)

ghost commented 7 years ago

Last commit makes shadow a bit transparent and fixes the window issue (by making it two-sided), also should fix #94

gilbertohasnofb commented 7 years ago

@D-ECHO Great, taking a look

gilbertohasnofb commented 7 years ago

Looks good, I am merging this. It's a pity that shadows are a bit buggy in FG (perhaps someone could talk to Thorsten about it), see for instance these two images:

fgfs-screen-003

fgfs-screen-004

ghost commented 7 years ago

Can be deleted?