search

vildanbina / livewire-tabs

Livewire component that provides you with a tabs that supports multiple tabs form while maintaining state.
MIT License
48 stars 10 forks source link

View error #1

Closed dwainscheeren closed 1 year ago

dwainscheeren commented 1 year ago

I just installed this on my Laravel 9.52.4 project with PHP 8.0.23.

But I get error

Declaration of Vildanbina\LivewireTabs\Components\Tab::view(string $view): static must be compatible with Illuminate\View\Component::view($view, $data = [], $mergeData = [])
dwainscheeren commented 1 year ago

I think public function view(string $view): static must be changed to public function viewContract(string $view): static on L:92 in Components/Tab.php regarding https://github.com/laravel/framework/commit/28e0f61bba1cbc727383d183b7116eb723de7660

vildanbina commented 1 year ago

Merged! thank you for your contribution