search

vilemduha / blendercam

Automatically exported from code.google.com/p/blendercam
GNU General Public License v3.0
468 stars 119 forks source link

Pack curves on sheet - not working #42

Closed narvf closed 8 years ago

narvf commented 8 years ago

curves-on-sheet.blend.zip

Blender file attached. I've used blender 2.69

Here is the output from console:

Traceback (most recent call last): File "/home/narvf/Pulpit/blendercam-master/scripts/addons/cam/ops.py", line 253, in execute pack.packCurves() File "/home/narvf/Pulpit/blendercam-master/scripts/addons/cam/pack.py", line 119, in packCurves if allpoly.disjoint(ptrans): AttributeError: 'PreparedGeometry' object has no attribute 'disjoint'

location: :-1

ghost commented 8 years ago

I get the same error with your blend in Blender 2.77 running Blendercam 9.1. Definite bug.

ghost commented 8 years ago

Found the problem. I think Vilem was in the process of speeding things up by using prepared geometry but its not complete.

But there is an easy fix to get it back to working but it will be slow again. If you are up to modifying one line of code then you could have it working again. Modify line 195 in scripts/addons/cam/pack.y from this: allpoly=prepared.prep(sgeometry.MultiPolygon(placedpolys)) to this: allpoly=sgeometry.MultiPolygon(placedpolys)

Just be warned that if you have a lot of curves it will be slow.

ghost commented 8 years ago

I committed the temporary fix to github master if you want to pull from github for the fix.

ghost commented 8 years ago

Took a crack at finishing the code to use prepared geometry. It provides about 30% speed improvement on my machine over the old method. Still room for improvement since its still slow. I committed the changes to master if you want to try it out.

narvf commented 8 years ago

Yes, now it is working! Thank you! There is something like svgnest.com, it is also open source - I've discovered it today. Seems to work faster. Maybe source code from there would be useful. https://github.com/Jack000/SVGnest

ghost commented 8 years ago

Thanks for the tip, I will have a look at svgnest.com.

vilemduha commented 8 years ago

sorry guys, seeing this discussion just now. that was really a stupid bug I didn't check when I was trying to use the prepared geometry all around blenderCAM. thanks for fixing, nfz! svgnest indeed looks promissing!