viletyy / gitea-client

Gitea API sdk
MIT License
1 stars 1 forks source link

Missing docs. And possibly a bug for a method "get_repos_commits_by_owner_repo"? #4

Closed rossanoua closed 1 year ago

rossanoua commented 1 year ago

Hi. Thank you for the nice repo. Is there some documentation?

And looks like a bug for method "get_repos_commits_by_owner_repo". I'm trying to use it like this: client.get_repos_commits_by_owner_repo(@owner, @repo, { "sha" => branch }) and this returns the same result client.get_repos_commits_by_owner_repo(@owner, @repo, { sha: branch })

and got different results from our Gitea API directly if compare it to results of mentioned method.

viletyy commented 1 year ago

Hi. Thank you for the nice repo. Is there some documentation?

And looks like a bug for method "get_repos_commits_by_owner_repo". I'm trying to use it like this: client.get_repos_commits_by_owner_repo(@owner, @repo, { "sha" => branch }) and this returns the same result client.get_repos_commits_by_owner_repo(@owner, @repo, { sha: branch })

and got different results from our Gitea API directly if compare it to results of mentioned method.

the third param should be a total hash, you can use it

$client.get_repos_commits_by_owner_repo(@owner, @repo, {query: {sha: branch}})