viliger2 / ShrineOfRepair

Risk of Rain 2 mod, adds shrine to repair items
Other
0 stars 2 forks source link

[Enhancement] 1.3.0 (perhaps) #2

Closed prodzpod closed 2 years ago

prodzpod commented 2 years ago

it also adds Regenerating Scrap and Trophy Hunter's Tricorn for the default recipes, feel free to remove them if you think its too much lol

viliger2 commented 2 years ago

Seems fine, I am guessing the idea behind replacing blacklist with repair list is to allow users themselves add repair pairs via config, especially for modded items. I don't see any issues outside of very minor code formatting. Tricorn and Regenerating Scrap are fine as additions, I completely forgot about them.

prodzpod commented 2 years ago

hi since you didnt merge yet i squeezed in 1 extra feature. blacklist was replaced because it would be redundant if people could just remove the entry.

viliger2 commented 2 years ago

If you are adding multiple uses then might as well add limit to number of uses, like majority of vanilla shrines do.

On August 24, 2022 12:43:33 AM GMT+03:00, prod @.***> wrote:

hi since you didnt merge yet i squeezed in 1 extra feature. blacklist was replaced because it would be redundant if people could just remove the entry.

-- Reply to this email directly or view it on GitHub: https://github.com/viliger2/ShrineOfRepair/pull/2#issuecomment-1224917383 You are receiving this because you commented.

Message ID: @.***>

prodzpod commented 2 years ago

alright, max uses it is (to be honest i was just avoiding it out of laziness). it's absolutely a janky hack though. please replace with more robust code once you're free.

viliger2 commented 2 years ago

Max uses were clearly done in a rush, you are only increasing them on client for Picker, resulting in server not even knowing about them, which you don't even need to do, we can just send the message to client when we reach required number of uses to disable intractable. And for Purchase it is not done at all outside of zero check to make it infinite. I am just gonna merge 1.3.0 commit, if you want to make a proper implementation of multiple uses you are free to do so, I am not gonna do it right now, maybe later.