viliger2 / ShrineOfRepair

Risk of Rain 2 mod, adds shrine to repair items
Other
0 stars 2 forks source link

[Enhancement] 1.2.2 #3

Closed prodzpod closed 2 years ago

prodzpod commented 2 years ago

kRpcHandleDeactivateClient might be using the wrong hash, please check the number the broken image in readme should work upon merge

viliger2 commented 2 years ago

I am surprised that you can change costType after initialization and spawnCard creation. And location for moon shrine is certainly interesting, I'll merge everything, except PickerDisplayStack. My reasoning is that I think it has no place in the mod, if someone wants to mod the UI, BetterUI does the job, meanwhile the UI in the game should remain as vanilla-like as possible, since modifying UI is not within the scope of this mod, we are modifying UI out of necessity to provide necessary information, such as price of repairs and new header text, if base game doesn't want to provide stack information on PickerPanel, then we will do the same. Also it just looks silly when PickerPanel has stacks for repair shrine, but not for command or scrapper.

viliger2 commented 2 years ago

Also if you want to continue adding to the mod, you can implement Risk Of Options support, this is something that I want to do in the future, but as I said earlier, I don't have the time on work on this mod right now.