Possible to support PSD import and export?

JordanMagnuson commented 4 years ago

First of all, this is an awesome open source project, and the feature list is impressive. Kudos!

The one big shortcoming, in terms of my own personal needs, is the inability to import and export Photoshop's native PSD file format (even if a limited implementation with basic layer importing).

Is supporting PSD something that has been considered? Any thoughts on how difficult it would be to add basic PSD support? My understanding is that the PSD specification is openly available, and I know that some HTML5 image editors support it.

Thanks for your thoughts!

viliusle commented 4 years ago

There are multiple reasons against PSD support:

PSD format is very complex to support. Even harder to keep with updates.
Basically only basic support can be done on browser. Most effect probably will not work. I mean it would work with simple "hello world" level PSD, but not with complex, real life PSD files, that can weight about 1 GB size. In most cases user will see inaccurate result !!!
There are some JS libraries, that tries to support PSD, but none are perfect: most are abandon or support only basic layer extraction, because of PSD is hard to support on browser.
You can disagree, but in latest years PSD is less important. For websites, people and companies are moving to sketch, adobe XD. There are lots of apps that lets you to do cool effects automatically, without boring manual work, like remove.bg for example. Or many phone apps for nice effects.

PSD export: would be really difficult, and not much useful i believe.

So it is possible to implement basic PSD import, but it would take time, would work with simple small files and would not give perfect results. Also not much people would use it. If somebody have Photoshop, he will not use miniPaint.

p.s. we have alternative for PSD in miniPaint - "JSON" - it will export layers data separately, and next time you open it, you will see same layers. (check menu > open > open test template for demo)

JordanMagnuson commented 3 years ago

I am currently looking at integrating the psd.js library to offer basic PSD importing (just the ability to import PSD layers would offer 90% of the benefit for most use cases, compared to PSD files being completely unreadable).

zavalzam commented 3 years ago

I am working with Jordan to try and integrate the psd.js library for basic psd importing. I am able to get all the metadata scraped from each layer such as height, layer name, etc. however, I am struggling to figure out how to get the actual layer data in (for example the actual image contained in the layer). I am using the load_json function as a reference for building up my load_psd function. Is there any advice you have that could help me solve this, particularly involving data types/formatting and how/where to put it? Thanks.

viliusle commented 3 years ago

So you have problems to extract image data from PSD or problems importing image data to miniPaint? If its is second case, can I find your code somewhere?

viliusle commented 3 years ago

Basically miniPaint internal data is array of layers. Each layer can have different type, but even if types are different, layer format is very similar. To get layer types list, open https://github.com/viliusle/miniPaint/blob/master/images/test-collection.json and search for: "type": I don't know about PSD object types, but some of them will probably match like line, circle, rectangle, image, some - will not, in this case we can try to convert it into image if possible and import it this way. And load_json is good place to look.

If you have some problems, try to share your code, so i can try to help. Maybe we will need to modify miniPaint core files to make some things possible. We will see.

viliusle commented 3 years ago

Also to insert new layer, use this as example: https://github.com/viliusle/miniPaint/blob/master/src/js/tools/shapes/line.js#L26

viliusle commented 3 years ago

I am working with Jordan to try and integrate the psd.js library

Any progress? Are you going to share your code so it can be implemented into https://viliusle.github.io/miniPaint/ ?

JordanMagnuson commented 3 years ago

Hi, yes, we have made some progress, and would be happy to share the code. Just a bit slow going a the moment, but we will share it.

wbuk commented 3 years ago

Hi, is there any progress on PSD? mini paint is fantastic, the latest features just make this awesome product even more impressive. Opening PSD and if possible SPP (Serif Photo Plus) files would be awesome. Any news on PSD files?

JordanMagnuson commented 3 years ago

@wbuk Yes, we have made some progress with basic PSD import. Unfortunately I've been busy with other things lately, but will be trying to make our miniPaint fork a priority again in the near future, and will plan to share our code once we get it cleaned up a bit.

JordanMagnuson commented 3 years ago

Sorry for they delay in sharing our changes. The problem is that we had a number of students work on our project, and the commit history became a bit of a mess. :-(

I was wanting to make a nice clean pull request with just the PSD integrations that we made, but I'm not sure when I will be able to do that currently. So for now, please feel free to take a look at our fork and find the PSD-related changes if you like: https://github.com/JordanMagnuson/miniPaint

I do apologize.

wbuk commented 3 years ago

Hi

That is no problem, we are so excited about being able to work with photoshop files, it will be so helpful.

Al

Karl Web Buster UK Ltd Awarded Best Web Design Company in North Yorkshire 2018 Awarded Best Innovative Web Design Company 2019 Awarded Most Outstanding Web Design & Hosting Services Provider 2021 - UK Awarded Best Budget Web Design Company in UK 2021 Awarded Best E-learning Platform in UK 2021 www.webbuster.co.uk @.***

On 09/09/2021 18:30, JordanMagnuson wrote:

Sorry for they delay in sharing our changes. The problem is that we had a number of students work on our project, and the commit history became a bit of a mess. :-(

I was wanting to make a nice clean pull request with just the PSD integrations that we made, but I'm not sure when I will be able to do that currently. So for now, please feel free to take a look at our fork and find the PSD-related changes if you like: https://github.com/JordanMagnuson/miniPaint

I do apologize.

-- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. Triage notifications on the go with GitHub Mobile for iOS [3] or Android [4].

Links:

[1] https://github.com/viliusle/miniPaint/issues/165#issuecomment-916296526 [2] https://github.com/notifications/unsubscribe-auth/AE2SEINPEHJY4CNQJLHC6OLUBDVKPANCNFSM4RDMC7ZA [3] https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 [4] https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

JordanMagnuson commented 3 years ago

We are back to work on this project, so hopefully will make a clean pull request with some basic PSD functionality soon.

wbuk commented 3 years ago

Oh that is awesome the students cant wait. We will test and het you feedback.

Al

⁣Sent from BlueMail

On 5 Oct 2021, 19:05, at 19:05, JordanMagnuson @.***> wrote:

We are back to work on this project, so hopefully will make a clean pull request with some basic PSD functionality soon.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/viliusle/miniPaint/issues/165#issuecomment-934642590

viliusle / miniPaint

Possible to support PSD import and export? #165

Links: