viliusle / miniPaint

online image editor
http://viliusle.github.io/miniPaint/
Other
2.74k stars 634 forks source link

Source-Atop does not work like a typical Clipping Mask #231

Closed marisalerin closed 2 years ago

marisalerin commented 3 years ago

I have been using the Layers -> Composition -> source-atop tool to "clip" the top layer to the layer below it as I would in Photoshop using a clipping mask. This is a very common function for me that I use constantly when doing graphic work. However, the source-atop setting in Mini Paint considers everything below the top layer, rather than just the layer below it, for the clipping function. (Photoshop and other image editors that I have used, only consider the layer directly below for clipping mask functionality).

Is this the intended functionality? It seems to me that it would make more sense to have this tool work like the clipping mask tool in Photoshop and GIMP?

I would much prefer to have the ability the clip one layer just to the layer below it, as in Photoshop (and to do this several times on one canvas). Whether this comes from the source-atop tool, or perhaps a new tool, it's a very valuable part of graphic work that I think should be considered.

Thanks for considering!

viliusle commented 3 years ago

Understood. I will double check it on Photoshop to confirm this.

Sample to reproduce: (open it with miniPaint, based on this issue, circle should be visible only inside rectangle area.) example.json.txt

JordanMagnuson commented 2 years ago

Nice work on this @kmanaseryan ! Initial testing looks good!