search

viliusle / miniPaint

online image editor
http://viliusle.github.io/miniPaint/
Other
2.73k stars 632 forks source link

IME input compatible #397

Closed new-sankaku closed 6 months ago

new-sankaku commented 6 months ago

The following issues have been fixed. I wrote the problem in an issues. IME input compatible #396

I've made a correction regarding an issue that caught my attention, although JavaScript is not my specialty. However, from what I've tested with Japanese and English inputs, it seemed to work without any problems.

The correction is as follows: When IME input begins, a compositionstart event is called, and when it ends, a compositionend event is called. For IME inputs, since the Input event stores the entire string in the buffer, I've concatenated the pre-held string before input and the string being input, replacing everything accordingly. There might be a better method, but I believe replacing everything should not be particularly heavy processing.

viliusle commented 6 months ago

I included your PR manually (wanted to ignore dist/* files).