vilkov / phonon-vlc-mplayer

Automatically exported from code.google.com/p/phonon-vlc-mplayer
GNU Lesser General Public License v3.0
2 stars 0 forks source link

r622 breaks build on mingw #17

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
/Zc:wchar_t- should only be set if the compiler is MS VC++, not for gcc. 

Something like:

if (${CMAKE_CXX_COMPILER_ID} STREQUAL "MSVC")
    set_source_files_properties(
        MediaInfoFetcher.cpp
        PROPERTIES COMPILE_FLAGS "/Zc:wchar_t-")
endif (${CMAKE_CXX_COMPILER_ID} STREQUAL "MSVC")

But I'm no CMake expert. There might be a better approach to this, as cmake
docs tell you not to use that variable:

  CMAKE_<LANG>_COMPILER_ID: An internal variable subject to change.

Original issue reported on code.google.com by christoph.gysin@gmail.com on 18 Dec 2008 at 12:19

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The right syntax is if (MSVC), if (MINGW)...
Anyway, I didn't try using MinGW lately and I had some problems with MinGW 
(contains
an old GCC version, that's why) in the past + even if it compiles it is 
difficult to
debug.

I will let you know about my findings

Original comment by tkrotoff on 31 Dec 2008 at 12:39

GoogleCodeExporter commented 9 years ago
I use the updated MinGW from nuwen.net, currently gcc-4.3.2.

But thanks anyway

Original comment by christoph.gysin@gmail.com on 1 Jan 2009 at 11:28

GoogleCodeExporter commented 9 years ago
I've fixed the compilation problem here:
http://code.google.com/p/phonon-vlc-mplayer/source/detail?r=666

Still QuarkPlayer compiled using MinGW from Qt-4.4.3 (I didn't try yet with the 
one
from nuwen.net) does not run fine :/

Original comment by tkrotoff on 3 Jan 2009 at 7:36