search

vilkov / phonon-vlc-mplayer

Automatically exported from code.google.com/p/phonon-vlc-mplayer
GNU Lesser General Public License v3.0
2 stars 0 forks source link

Memory leak and unwanted return values in phonon mplayer backend #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
phonon-mplayer/Effect.cpp Effect::parameterValue

and

phonon-mplayer/MediaController::interfaceCall

both return a QVariant containing a pointer to another QVariant in an
error condition.
This creates a memory leak (the newly created QVariants never get deleted)
and breaks error handling (calling applications checking if the returned
QVariant isValid() will wrongfully assume it is valid -- the pointer to an
invalid QVariant is a valid QVariant).

Fix attached.

Original issue reported on code.google.com by bero%ark...@gtempaccount.com on 4 Mar 2009 at 2:36

Attachments:

GoogleCodeExporter commented 8 years ago 
Fix in revision 728
See http://code.google.com/p/phonon-vlc-mplayer/source/detail?r=728

Thanks for the patch, sorry for the late commit

Original comment by tkrotoff on 18 Mar 2009 at 4:43