search

vilkov / phonon-vlc-mplayer

Automatically exported from code.google.com/p/phonon-vlc-mplayer
GNU Lesser General Public License v3.0
2 stars 0 forks source link

Implement aboutToFinish #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What about implementing aboutToFinish and setPrefinishMark for the mplayer
backend?

Original issue reported on code.google.com by Jason.Donenfeld on 12 Jun 2008 at 1:59

GoogleCodeExporter commented 9 years ago 
Just done it, diff here:
http://code.google.com/p/phonon-vlc-mplayer/source/diff?r=201&format=side&path=/
trunk/vlc-mplayer/MediaObject.cpp
Example how to use it:
http://code.google.com/p/phonon-vlc-mplayer/source/diff?r=202&format=side&path=/
trunk/quarkplayer/StatusBar.cpp

Original comment by tkrotoff on 12 Jun 2008 at 4:24

GoogleCodeExporter commented 9 years ago 
Seems to work well.

Disabled the seek bar for non-seekable streams. Before this commit, for 
non-seekable
streams, the bar would be disabled, but the marker would still move. Now the 
marker
does not even move for non seekable streams.

enqueue does not work. Mplayer goes to play the next song, but mysteriously 
finds end
of file right away, even though setSource is called both for playing a song out 
of
the queue and from setCurrentSource. So, it must be some sort of state 
condition that
is bad. Perhaps with the mplayer process?

Original comment by Jason.Donenfeld on 12 Jun 2008 at 7:03

GoogleCodeExporter commented 9 years ago 
> Disabled the seek bar for non-seekable streams.

MPlayer sends a ID_SEEKABLE that is catch inside MPlayerProcess class.
Unfortunatly this feature was only implemented in march 2008 cf
http://lists-archives.org/mplayer-dev-eng/22843-add-id_seekable-information-for-
identify-argument.html
I guess you are under Linux and distributions only provide MPlayer-1.0rc2 which 
is
quite old. So by default all streams are seekable.
Under Windows, if you use the MPlayer build of SMPlayer, it works fine.

> enqueue does not work

True, I just checked this. Wait for me to implement it :p

Original comment by tkrotoff on 12 Jun 2008 at 11:59

GoogleCodeExporter commented 9 years ago 
All the queuing issues should be fixed now

Original comment by tkrotoff on 28 Nov 2008 at 5:15