search

villadora / express-http-proxy

Proxy middleware for express/connect
Other
1.22k stars 236 forks source link

Instead of new Buffer using Buffer.from #523

Closed bmhaskar closed 1 year ago

bmhaskar commented 1 year ago

As per https://nodejs.org/api/buffer.html#buffer_new_buffer_string_encoding new Buffer is deprecated changing code to use Buffer.from

bmhaskar commented 1 year ago

I have also included node 16.x to testing since it is next its version. It tries to fix current master test fails by increasing timeout the issue is only node 14.x other version pass the tests without the overall timeout increase

monkpow commented 1 year ago

@bmhaskar Thanks for this commit! I cherry-picked the update to Buffer.from to main. I didn't want the yarn.lock file or the increases for timeout, so I've left those off for now. Thanks, and let me know if you have any further suggestions.

monkpow commented 1 year ago

0babc9c22fdbd25d9730f7d4687f82564a25c913