search

villagedefrance / OpenCart-Overclocked

OpenCart Overclocked Edition. Advanced Shopping Cart CMS based on OC v1.5.6.X source code.
https://villagedefrance.net
Other
31 stars 22 forks source link

SwipeBox lightbox has stopped working. #187

Closed villagedefrance closed 6 years ago

villagedefrance commented 6 years ago

SwipeBox doesn't work as expected anymore. A fix is unlikely, so chances are a replacement will be needed. Any suggestions?

Tangol commented 6 years ago

Found 2 alternatives that seem nice:

  1. Lightcase.js
  2. PhotoSwipe

I would pick the one that's lighter on resources.

villagedefrance commented 6 years ago

Thanks Tangol,

I had a look at both the options you suggested, both good, but I ended-up with another one which looks more similar in style to SwipeBox. It's called "GLightbox". The code seems to be well maintained and very well written too, so I went for it.

I have done the implementation on local and all looks good. I will be committing the update very shortly. Still need testing Touch/Swipe on mobile properly later.

Tangol commented 6 years ago

Please note that SwipeBox still appears as an option in the News Module, so it needs to get updated there also.

swipe

Tested on https://github.com/villagedefrance/OpenCart-Overclocked/commit/af061b111c8977478be878cb4ec1729b8e47a288

Tangol commented 6 years ago

Please note that now, when trying to use GLightbox for the News Module, gets ColorBox loaded instead.

gli colorbox

Tested on https://github.com/villagedefrance/OpenCart-Overclocked/commit/a7118d7aad6520212b89f3da40b458fd0fbe21a7

Tangol commented 6 years ago

Viewbox seems to be working nice. The issue can be closed.

Thanks!