search

villagedefrance / OpenCart-Overclocked

OpenCart Overclocked Edition. Advanced Shopping Cart CMS based on OC v1.5.6.X source code.
https://villagedefrance.net
Other
31 stars 22 forks source link

[1.7.4] EU taxes works only in English #40

Closed gob33 closed 8 years ago

gob33 commented 8 years ago

As EU taxes installs its own table 'eucountry_description', it is not touched when adding/removing a new language, so that it displays no EU country (empty result) when admin is in another language than English. Should it be part if the core ? I see it rather as an extension, or you must rewite it.

villagedefrance commented 8 years ago

OCE is meant to be International, not just European, so EU taxes are optional. Also EU Taxes are ONLY for Digital Goods, not manufactured products, so again optional in most cases. Like OpenBay and vQmod, it is a modification only. I added it because I had a request for such extension over a year ago, for which I made a module in English and French. Sadly I don't speak German, Greek, Portuguese or Dutch ... so to be fair to everyone, I only provided the English SQL in OCE as a reference and descriptions can be manually adjusted for each language. This is also something the OpenCart Team always refused to implement (like the Cookie Policy) in the official releases, probably because it is too localised for them, and they want to remain fully International. So I added it as a bonus, a time saver for developers in Europe.

gob33 commented 8 years ago

Yes I understand usage but it is not fully integrated into the core. For that, its tables should be in opencart.sql, not in the install() function. Like that when installing a new language, descriptions would be duplicated and not being inexistant.