search

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

`example-usecase` directory could use requirement.txt in addition to environment.yml #14

Closed nuclearGoblin closed 3 years ago

nuclearGoblin commented 3 years ago

From matthewfeickert in openjournals/joss-reviews#3174 on 04/29/21:

There is a Conda environment.yml, but one should also include a requirement.txt, as there is nothing specific about Conda or any Conda-forge libraries that are needed for the example --- everything can be installed from PyPI.

Description: There is an environment.yml, but since it is possible, there should also be a requirement.txt.
Solution: Add a working requirement.txt.
Testing: There should likely be a secondary CI test of the notebook using the pip-based installation to ensure that the file is configured correctly.

nuclearGoblin commented 3 years ago

File added by #15 - resolved.