Feature/logging - Githubissues

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.

MIT License

0 stars 1 forks source link

Feature/logging #16

Closed nuclearGoblin closed 3 years ago

nuclearGoblin commented 3 years ago

Attempt to address #12 by shifting most of the logging from cout to a user-specified (optional) text file. I do not believe that there are any breaking changes in my implementation. I have tested locally that it still works both with and without a log file specified (and CI shows that it still works without the new flag). Requesting @villaa to review this as I believe he can answer whether this will result in any breaking changes, what kind of version change will be needed, and whether any further testing is necessary.

nuclearGoblin commented 3 years ago

Tweaked the verbosity settings a little bit. I'm not sure if I'm following standard pracitces for them correctly, but:

Fixed a bug where -s did not work because of the added text for the seed.
Removed -q since it was the same as -s.
Re-included the stdout printing for cascade information at -v 2 or greater.