search

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

Installation fails at make #2

Closed nuclearGoblin closed 3 years ago

nuclearGoblin commented 3 years ago

From matthewfeickert in openjournals/joss-reviews/issues/3174 on 04/29/21:

If the bin/lib directory is manually created by the user (it should not need to be) then make will succeed with a large number of warnings from the vendored distribution of the Mersenne prime algorithm.

Description: If following the installation directions given, the command make fails because the bin/lib directory is not present. There are also a large number of warnings (these will be submitted as a separate issue).

Solution: Have make create the bin/lib directory.

Testing: No automated testing was performed for the make process.

nuclearGoblin commented 3 years ago

Issue resolved in 8beac0b6418b029f53bb7e25b68f7a8c2a4f2d69 on branch release/1.0.4. This commit and all other commits referenced in this comment are part of 1.0.4 and were submitted before switching to PR-based issue resolution; after v1.0.4 is released, issues will be resolved with pull requests.

Solution: Have make create the bin/lib directory.

Resolution: The make command now succeeds without the user needing to create the bin/lib directory.

Testing: Automated testing for make process added in 9e92fbf228cfe77f396fc639c8f296e9d1cb6d33 and build passing as of 60440c3b4f1cb29276b52b505f01c9f0e44fa629.

Issue will be marked resolved when v1.0.4 is released.

nuclearGoblin commented 3 years ago

Discussed with villaa and will be resolving now - issues will be resolved when a commit/pull request fixes the issue, rather than waiting for the fix to be pushed to master.