search

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

Inconsistency with documentation on lifetime units in levelfiles #53

Closed nuclearGoblin closed 2 years ago

nuclearGoblin commented 2 years ago

Found an inconsistency in the documentation on levelfiles:

100000000000000.0 (1e+14 as, or 1 ms)

I am not sure which is true - if the units of the lifetimes are attoseconds, or if the 1e+14 entry is equivalent to 1 ms. They cannot both be true, as 1e+14 as is only equivalent to 0.1 ms. It seems more likely that the attosecond unit is correct, but we should confirm this before fixing the docs.

nuclearGoblin commented 2 years ago

In a comments in the code (see src/cascadeProd.c, line 54), it says that lifetimes are taken to be in femtoseconds. I compared some of the levelfile data with the data found on nudat and they appear to use femtoseconds. So, everything (fortunately) seems to be consistent in the code - just the documentation needs to be fixed.