villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

Increase and track coverage #69

Closed nuclearGoblin closed 2 years ago

nuclearGoblin commented 2 years ago

Does your pull request resolve or partially resolve an issue? Yes, fully.

If Yes, which issue? Resolves #49, #37, and #44.

Does your pull request implement code improvements? Yes.

Does your pull request implement any breaking changes? Yes/Unsure.

If breaking changes are implemented, please describe: The example notebook example-usecase/Yields_and_Resolutions.ipynb will still provide at least the output it provided before. However, in order to run it fully with no errors, the user must now use the main realizeCascades program.

Testing:
This pull request: [X] Alters the existing CI in some way. [X] Adds a new step to the CI. [ ] Does not introduce any features that the CI could not already test. [ ] Is not accompanied by necessary CI changes due to some limitation described below. (Please also describe how new features can be manually tested.)

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7e72edf). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #69   +/-   ##
==========================================
  Coverage           ?   81.80%           
==========================================
  Files              ?       12           
  Lines              ?     1253           
  Branches           ?        0           
==========================================
  Hits               ?     1025           
  Misses             ?      228           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e72edf...6122ae1. Read the comment docs.

nuclearGoblin commented 2 years ago

We will need to remember to change the default branch for Codecov to develop once the merge is complete!