search

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

[JOSS Review]: Clarify units of input values in functions #74

Closed altavir closed 2 years ago

altavir commented 2 years ago

The units for masses and energies should be clarified in method documentation. Like here: https://github.com/villano-lab/nrCascadeSim/blob/4f349d1de796e099db4af9f381b8ece16c894f33/src/cascadeProd.c#L459

It looks like the energy is in eV, but the mass in GeV, which is a bit confusing without documentation.

villaa commented 2 years ago

resolved by #78