villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

Functionality Documentation - Clarity Issues #8

Closed nuclearGoblin closed 3 years ago

nuclearGoblin commented 3 years ago

From matthewfeickert in openjournals/joss-reviews#3174 on 04/29/21

Typos in the documentation should be checked for and corrected. There is some brief description of the custom .txt file format (the "levelfiles") but it is not well formatted for Markdown and lacks a full description of the schema and clear examples. There are also what appear to be "TODO"s written by the authors to themselves

Check that the below is correct!

that should be removed.

Description: There are issues with spelling/grammar or other typoes, there are leftover "TODO"s, and the the levelfile documentation is unclear.

Solution: Check spelling/grammar and leftover "TODO"s and work on the writing and formatting for levelfile documentation.

Testing: N/A (Documentation)

nuclearGoblin commented 3 years ago

I have checked the README over for typos already and found a few, but I'm not sure I found all of them. @villaa would you be willing to help me look for them? Thanks!

villaa commented 3 years ago

Addressed fully in PR #20