villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

Bugfix/unsafe memory access #82

Closed nuclearGoblin closed 2 years ago

nuclearGoblin commented 2 years ago

Does your pull request resolve or partially resolve an issue? Yes.

If Yes, which issue? This resolves #73.

Does your pull request implement code improvements? Yes.

Does your pull request implement any breaking changes? Yes.

If breaking changes are implemented, please describe: The way memory is handled has been reworked. Except where necessitated by ROOT-related functions, all arrays have been changed to vectors. This means all uses of malloc and free have been removed, including a few functions designed to free allocated memory that were previously part of the API.

Testing:
This pull request: [ ] Alters the existing CI in some way. [ ] Adds a new step to the CI. [X] Does not introduce any features that the CI could not already test. [ ] Is not accompanied by necessary CI changes due to some limitation described below. (Please also describe how new features can be manually tested.)