search

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

[JOSS Review] Remove `.gcno` and `.gcda` files during the `clean` target. #84

Closed nuclearGoblin closed 2 years ago

nuclearGoblin commented 2 years ago

From the review thread:

Add removal of the .gcno and .gcda files generated during the build to the clean Make target. Clean target should get rid of all generated files; these weren't added to the clean target when these files were introduced.

matthewfeickert commented 2 years ago

From: https://github.com/openjournals/joss-reviews/issues/3993#issuecomment-1015075303

When the default Make target

https://github.com/villano-lab/nrCascadeSim/blob/bf4795d83f8be6c9c1d737f5f51741def32cceb5/Makefile#L33

is run, it can generate .gcno and .gcda files that after compilation are artifacts. These should get added for removal in the clean Make target

https://github.com/villano-lab/nrCascadeSim/blob/bf4795d83f8be6c9c1d737f5f51741def32cceb5/Makefile#L86-L99

villaa commented 2 years ago

Now that we've moved to CMake try this link.

villaa commented 2 years ago

In CMake can't set clean target well and the above link doesn't do the cleaning upon make clean but before the next build.

However could try the solution suggested in these links: 1, 2.

Basically, this would be to use the set_directory_properties to add *.gcda to the list of files that are removed on make clean.

villaa commented 2 years ago

@gerudo7 showed me this reference for suggestions on cleaning up these kinds of files.

villaa commented 2 years ago

Trying to borrow stuff from this reference too.

villaa commented 2 years ago

Fixed with PR #99