search

villano-lab / nrCascadeSim

calculating the NR spectrum resulting from neutron-capture cascades.
MIT License
0 stars 1 forks source link

Create notebook for comparison with Geant4 #98

Closed nuclearGoblin closed 2 years ago

nuclearGoblin commented 2 years ago

Does your pull request resolve or partially resolve an issue? Yes.

If Yes, which issue? Resolves #75.

Does your pull request implement code improvements? Yes(?) - Adds comparison with Geant4

Does your pull request implement any breaking changes? No.

Testing:
This pull request: [ ] Alters the existing CI in some way. [X] Adds a new step to the CI. [ ] Does not introduce any features that the CI could not already test. [ ] Is not accompanied by necessary CI changes due to some limitation described below. (Please also describe how new features can be manually tested.)

Requesting review because I don't have much knowledge about Geant4 as I hadn't used it before working on this comparison. The data is there and I have tried to lay it out in a way that makes sense for comparing them to me. The results of the two programs are different, but I don't know the best way to perform an unbiased evaluation of which is more correct.

codecov-commenter commented 2 years ago

Codecov Report

Merging #98 (fff32a5) into develop (24292f7) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #98   +/-   ##
========================================
  Coverage    82.57%   82.57%           
========================================
  Files           13       13           
  Lines         1245     1245           
========================================
  Hits          1028     1028           
  Misses         217      217

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24292f7...fff32a5. Read the comment docs.

nuclearGoblin commented 2 years ago

@villa Plots have been changed to fix the axis labels and it looks like the docs are building now. (The scale of the data itself was already updated to eV - but I forgot to update the axis labels when I did that.)