villasv / aws-airflow-stack

Turbine: the bare metals that gets you Airflow
https://victor.villas/aws-airflow-stack/
MIT License
377 stars 69 forks source link

Document the deployment lifecycle hook impact on the load metric #143

Closed villasv closed 4 years ago

villasv commented 4 years ago

When each instance is fully configured and passes the Amazon EC2 health checks, it is attached to the Auto Scaling group and it enters the InService state. The instance is counted against the desired capacity of the Auto Scaling group.

https://docs.aws.amazon.com/autoscaling/ec2/userguide/AutoScalingGroupLifecycle.html

villasv commented 4 years ago

Renamed because health checks serve a different purpose.

villasv commented 4 years ago

According to this blog post, this is already a feature of CodeDeploy. Instances will only be marked as InService after the deployment completes successfully.

Now we just need to document this behavior.