search

villermen / runescape-cache-tools

A .NET library and command-line interface to interact with RuneScape's cache.
MIT License
78 stars 17 forks source link

DecodeException while combining soundtrack after 7-1-2019 update #63

Closed chuhei1987 closed 5 years ago

chuhei1987 commented 5 years ago

I have received an error like this, I try to use older method to find out the root cause.

E:\runescape-cache-tools-v3.0.4>rsct304 -c="C:\Users\konyzulphurea\Desktop\RSCD\data" -s Villermen.RuneScapeCacheTools.Exceptions.DecodeException: Enum data does not contain a key type. at Villermen.RuneScapeCacheTools.Cache.Files.EnumFile.Decode(Byte[] data) at Villermen.RuneScapeCacheTools.Cache.Files.CacheFile.FromDataFile(BinaryFile dataFile) at Villermen.RuneScapeCacheTools.Cache.CacheBase.GetFile[T](Index index, Int32 fileId, Int32 entryId) at Villermen.RuneScapeCacheTools.Soundtrack.GetTrackNames(Boolean includeUnnamed) at Villermen.RuneScapeCacheTools.Soundtrack.Extract(Boolean overwriteExisting, Boolean lossless, Boolean includeUnnamed, String[] nameFilters) at Villermen.RuneScapeCacheTools.CLI.Program.CombineSoundtrack() at Villermen.RuneScapeCacheTools.CLI.Program.Main(String[] args)

E:\runescape-cache-tools-v3.0.4>

villermen commented 5 years ago

@konyzulphurea Thanks for reporting. I got the same error yesterday trying to update my local copy of the soundtrack. It's probably a logical error on my part or a change in Jagex's protocol. I'm going to look into it and hopefully have it fixed before this weekend.

chuhei1987 commented 5 years ago

That's so fast, by the way, I might try using older ways to take a look.

chuhei1987 commented 5 years ago

I personally have found the initial version can combine sound with a little trick found from https://www.rune-server.ee/runescape-development/rs-503-client-server/downloads/252701-rs-cache-downloader.html

chuhei1987 commented 5 years ago

It looks like there are some logic issues at 3.0.4 during using old ways, Which is your 1.0.0 version with modified cache downloader (Whooping 13GB) , index 17 and index 40 is nothing changed.

chuhei1987 commented 5 years ago

I personally have tried the 1.0 version with the current effective rscd (modified not for splitting) , Seems there are some logical errors at 3.0.4 as I roughly tested few hours ago. 17 and 40 are nothing changed at a moment.

Sjoerd Nuijten notifications@github.com 於 2019年1月8日 週二 19:36寫道：

@konyzulphurea https://github.com/konyzulphurea Thanks for reporting. I got the same error yesterday trying to update my local copy of the soundtrack. It's probably a logical error on my part or a change in Jagex's protocol. I'm going to look into it and hopefully have it fixed before this weekend.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/villermen/runescape-cache-tools/issues/63#issuecomment-452268314, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTjylrI2CWpVACr7TYaZwAnqt6tinzxks5vBIK5gaJpZM4Z1S2- .

villermen commented 5 years ago

@konyzulphurea I think I fixed this issue over a year ago but haven't pushed a new release because the program wasn't in a fully working state yet. I hopefully fixed that now (but I'm a bit rusty). It worked for me. Can you check if it works for you with v3.1.0? Please take note of the release message if you're going to be using it on an existing soundtrack directory.

Thanks in advance.

chuhei1987 commented 5 years ago

I take a look later.

Sjoerd Nuijten notifications@github.com 於 2019年1月11日 週五 04:43寫道：

I think I fixed this issue over a year ago but haven't pushed a new release because the program wasn't in a fully working state yet. I hopefully fixed that now (but I'm a bit rusty). It worked for me. Can you check if it works for you with v3.1.0 https://github.com/villermen/runescape-cache-tools/releases/tag/v3.1.0? Please take note of the release message if you're going to be using it on an existing soundtrack directory.

Thanks in advance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/villermen/runescape-cache-tools/issues/63#issuecomment-453246334, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTjyh7WoRGcIqiLd8ZCq-DCGMGllL6sks5vB6XngaJpZM4Z1S2- .

chuhei1987 commented 5 years ago

It is bascially dealt. I'm testing if there are more issues.

villermen commented 5 years ago

Great. I'll check up on it soon™ to see if anything broke as well. If you do find anything feel free to create a new issue for it.