Add gruvbox theme - Githubissues

vim-airline / vim-airline-themes

A collection of themes for vim-airline

MIT License

2.05k stars 350 forks source link

Add gruvbox theme #121

Closed jsatk closed 6 years ago

jsatk commented 6 years ago

Taken from the official gruvbox repo. https://github.com/morhetz/gruvbox/blob/master/autoload/airline/themes/gruvbox.vim

chrisbra commented 6 years ago

why do we need it here, if it is included with the gruvbox colorscheme?

jsatk commented 6 years ago

So people don’t need to know about and also install a separate plugin just to get one colorscheme. I love having all my colorschemes in one place and from one plugin.

On Dec 28, 2017, at 02:26, Christian Brabandt notifications@github.com wrote:

why do we need it here, if it is included with the gruvbox colorscheme?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

chrisbra commented 6 years ago

I am not sure I understand. To be able to use the gruvbox colorscheme, people need to install the gruvbox plugin (which includes a theme for vim-airline). Now we can of course copy the vim-airline theme here, but there are a couple of issues I like to mention:

people would still need to install the gruvbox plugin, because just using the gruvbox airline theme does not make much sense
- how do we keep the themes in sync if we start to distribute it in two different projects?

jsatk commented 6 years ago

@chrisbra you're totally right. Oversight on my part. Thanks for clarifying. I'll close.