search

vim-airline / vim-airline-themes

A collection of themes for vim-airline
MIT License
2.05k stars 350 forks source link

Insert mode color not showing correctly in 'hybrid' theme #126

Closed ericmarkmartin closed 6 years ago

ericmarkmartin commented 6 years ago

The RGB color code is supposed to be #81a2be, which is a cool gray-blue, but it's instead showing up as an ugly gray that renders the text 'INSERT' somewhat difficult to read.

screen shot 2018-02-10 at 3 08 40 pm

chrisbra commented 6 years ago

Well, since this is in a terminal, it could be, that not the rgb color is used but instead one of the 256 colors (or even less, depending on your terminal). However needs more information.

ericmarkmartin commented 6 years ago

I'm using 256 colors, and from the screenshots I've seen the color should be less gray.

chrisbra commented 6 years ago

First of all, what makes you think, that hybrid should use #81a2be? My hybrid theme uses #d277af and I cannot tell, whether this is correct. Second of all, there is a difference to be considered between the RGB colors and the terminal colors, if you do not use :set termguicolors

chrisbra commented 6 years ago

any update here?

ericmarkmartin commented 6 years ago

I do use :set termguicolors. I am assuming that is should use #81a2be because that is what is in the code for the theme, which doesn't match what is being rendered.

chrisbra commented 6 years ago

When I load the hybrid theme and the hybrid colorscheme, the airline section airline_a is airline_a xxx term=bold cterm=bold gui=bold guifg=#c5c8c6 guibg=#81a2be So I suppose that is correct then.

chrisbra commented 6 years ago

BTW: this color comes right from here: https://github.com/vim-airline/vim-airline-themes/blob/b0fca80555b8249f3c62271b7635542a7de22363/autoload/airline/themes/hybrid.vim#L17-L20

e.g. it uses the background from the DiffText highlighting. So I suppose when you are using vimdiff and the hybrid colorscheme, the color looks the same.