search

vim-airline / vim-airline-themes

A collection of themes for vim-airline
MIT License
2.05k stars 350 forks source link

Make base16_shell work for all uses of base16-vim, and rename accordingly #153

Closed danielwe closed 6 years ago

danielwe commented 6 years ago

The base16_shell theme adapts to match the selected base16-vim colorscheme, but only if base16-shell is used to configure the underlying terminal. This restriction is unnecessary: base16-vim can be used without base16-shell (either in gvim, or with termguicolors set), and the color palette is always exposed. This PR makes the theme work in all contexts, and renames it accordingly to base16_vim. Backward compatibility is retained by keeping base16_shell as an alias for base16_vim.

I also renamed the g:airline_base16_solarized option to g:airline_base16_monotone, since it has nothing to do with solarized in principle. (I actually prefer it for most, if not all, base16 themes.) Here, too, backward compatibility is retained.

danielwe commented 6 years ago

On a related note, there is a long list of static base16 themes that were autogenerated at some point. It seems quite stale compared to the present state of the base16 collection; some schemes are gone and many more have been added. Would it be a good idea to remove these from the repo? It looks like they were all made from the same template for mapping palette colors to airline elements, so we could just add an option for base16_vim to use this template instead of the default one.

It may be a good idea to keep the ones that are no longer part of the official base16 collection, though, since they wouldn't be available any other way.

chrisbra commented 6 years ago

Thanks looks good.

It looks like they were all made from the same template for mapping palette colors to airline elements, so we could just add an option for base16_vim to use this template instead of the default one.

Yes, as far as I remember, those were some how auto generated. I fixed some wrong colors and commited them. However if they are not used, I am fine with removing at least the ones that no longer exists. If people complain, we can restore them (but I really doubt it).

danielwe commented 6 years ago

OK, I might take a look at it later. I think it would make things a little less confusing and overwhelming. It did take me a while to figure out how to make the themes and colorschemes work together (hence this PR). But hopefully, the rewritten docs help make things a little clearer already.