search

vim-airline / vim-airline-themes

A collection of themes for vim-airline
MIT License
2.04k stars 348 forks source link

update colours for both Ubaryd and Laederon themes #161

Closed Donearm closed 5 years ago

Donearm commented 5 years ago

version updating for both themes

chrisbra commented 5 years ago

why are those colors changed?

Donearm commented 5 years ago

I've tweaked the airline theme to match better the original ViM theme and to fix high contrast occasions that previously made the airline themes not so nice to stare at

chrisbra commented 5 years ago

hm, Should that be made configurable?

Donearm commented 5 years ago

by changing the palette global variable it is configurable but I don't see the need of letting users change colours. If you don't like a them just choose another one, no?

chrisbra commented 5 years ago

I just want to give users being used to the current theme the possibility to keep on using those colors. Taste is a very individual thing....

Am 11.11.2018 um 11:57 schrieb Gianluca Fiore notifications@github.com:

by changing the palette global variable it is configurable but I don't see the need of letting users change colours. If you don't like a them just choose another one, no?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

chrisbra commented 5 years ago

But perhaps we should only do it if someone complains....

Am 11.11.2018 um 11:57 schrieb Gianluca Fiore notifications@github.com:

by changing the palette global variable it is configurable but I don't see the need of letting users change colours. If you don't like a them just choose another one, no?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Donearm commented 5 years ago

Usually, that's what forks and issues are for :wink:

anyway, do you have an example of how to make the switch easy from the new to the old, and viceversa, with a global variable, perhaps? I admit I wouldn't know where to start to implement it

chrisbra commented 5 years ago

let me merge it and await complaints ;)

chrisbra commented 5 years ago

here we go: #162