search

vim-airline / vim-airline-themes

A collection of themes for vim-airline
MIT License
2.04k stars 348 forks source link

Too many elements have got the same color in base16 summerfruit dark #198

Closed GordianDziwis closed 3 years ago

GordianDziwis commented 4 years ago

This picture shows that, the middle section of the active status line, the inactive status line, the background of floating windows and the selected line in the location list have the same color.

Screenshot_2019-12-12_22-12-40

I changed my theme by editing the summerfruit dark thme file and now it looks like this: Screenshot_2019-12-12_22-32-06

I would like to create a pull request for updating the base16 templates. Against which repo should I do this?

chrisbra commented 4 years ago

you can use this repo. However please make sure to add a configuration switch and document the variable in the documentation. Thanks!

chrisbra commented 4 years ago

are you going to fix this here as well?

GordianDziwis commented 4 years ago

This fix was my first naive try. To really get a consistent look I had to modify base16-vim: Base16 for Vim too.

Additionally in his there are multiple base16 colorschemes for airline. First the meta base16 scheme with takes its' highlights from the current base16 vim colorscheme and the other base16_* colorschmes rendered with these templates fnurl/base16-vim-airline: Base16 for vim-airline. Two solutions for one problem.

I did not commit my changes, because the general feedback was that highlights are opinionated and my consistent look works for one of the base16 colorschemes and with my collection of vim plugins. I dont know about the other.

image

And I used a lighter grey for the CursorLine highlight I think this is highly likely a nonstarter for people who have set the cursorline.