base16 themes are almost all the same

Felixoid commented 3 years ago

environment

vim: VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Feb 09 2021 23:51:55) Included patches: 1-2489
vim-airline: 07ab201a272
colorscheme: base16_ashes
OS: Arch linux
Have you reproduced with a minimal vimrc:

call plug#begin('~/.vim/plugged')
Plug 'vim-airline/vim-airline-themes'
Plug 'vim-airline/vim-airline'
call plug#end()

let g:airline_theme = 'base16_ashes'

What is your airline configuration: see above if you are using terminal:
terminal: alacritty
$TERM variable: xterm-256color, screen-256color
color configuration (:set t_Co?): t_Co=256 if you are using Neovim:
does it happen in Vim: ???

actual behavior

After https://github.com/vim-airline/vim-airline-themes/commit/fa3911ebbdf80a88dcab7c948de33865c8b161ed most of the randomly checked base16* themes looks the same (the left part on the screenshot)

expected behavior

The right part of the screenshot, the commit https://github.com/vim-airline/vim-airline-themes/commit/fa808d74e0aacf131337b58f01ee45fd3d3588af

screen shot (if possible)

screen_2021-04-17-00-32-32

cassanof commented 3 years ago

yeah, my gruvbox theme transformed into a black/white theme: https://imgur.com/Anktlkc.png

happy-dude commented 3 years ago

There was a similar issue with https://github.com/vim-airline/vim-airline-themes/issues/250

It's worth pinging @ShiromMakkad to see how the color schemes were changed and how they were validated as correct or still working in https://github.com/vim-airline/vim-airline-themes/pull/244

If the code isn't easy to fix, then perhaps it's worth rolling the commit back and cherry-picking the ones that are still working as intended?

chrisbra commented 3 years ago

okay, we just may need to revert that PR #244

Felixoid commented 3 years ago

Please, I am begging you to do so ^_^

justinpage commented 3 years ago

@Felixoid What happens if you set the following: let g:airline_theme = 'base16'? Does that match the colors you expect?

ensia96 commented 3 years ago

After update, the 'base16_gruvbox_dark_hard' theme is not working properly.

Seeing that the 'red' color looks like the 'original red', it seems that the color values aren't being reflected properly.

Sorry for not providing detailed information. : (

felipemlemos commented 3 years ago

The same is happening with base16_monokai. I did a revert on my machine of #244 and it fixed it for me. It seems it is probably happening with other themes as well. Do you mind if I create a PR to fix base16_monokai?

Felixoid commented 3 years ago

@justinpage hello. I am not sure what do you mean by "colors I expect". I don't use the scheme. But it looks definitely different compared to working commit
Screenshot_20210502_123725

Can you, maybe, consider reverting #244 and make a proper update lately? The current state looks very wrong to me

btalb commented 3 years ago

Also would support reverting. My themes have gone from left to right since recent updates:

airline_themes_base16

None of the base16 themes seem to change from this new washed out normal mode.

Possibly not the best place to ask, but what I've never understood is why all the different base16 themes are needed. Can't you just set the base16 scheme in your terminal app, and then vim outputs the same ANSI escape codes for every base16 colour scheme?

So all that would be required here is the different airline modes like Tmuxline's airline, airline_insert, airline_visual themes?

chrisbra commented 3 years ago

Okay, if I haven't done anything wrong, it should be reverted now. I don't know how to revert in git very well, so I hope I did not brake too much :/

cassanof commented 3 years ago

There is a bigger problem now. The theme colors are all off. Didn't remember Gruvbox looked like this https://imgur.com/FiEOnwh.png 😆

chrisbra commented 3 years ago

Hm, are those now not like: fa808d74e0aacf131337b58f01ee45fd3d3588af ?

vim-airline / vim-airline-themes