search

vim-airline / vim-airline-themes

A collection of themes for vim-airline
MIT License
2.04k stars 348 forks source link

missing solarized dark theme #86

Closed djdanielsson closed 7 years ago

djdanielsson commented 7 years ago

I noticed that solarized dark theme is missing from the themes folder and I would love to have that as an option again.

chrisbra commented 7 years ago

What do you mean with missing? Was this ever there?

djdanielsson commented 7 years ago

you show it as an option right here https://github.com/vim-airline/vim-airline/wiki/Screenshots#solarized-dark so I would have thought so

chrisbra commented 7 years ago

Isn't that just the normal solarized theme with bg=dark?

djdanielsson commented 7 years ago

I don't know how to set it as that, but I would like to have my airline look like that, I tried :AirlineTheme solarized dark and that does not work, I assumed that the name you had listed would be the name of the theme like all the others.

chrisbra commented 7 years ago

That has nothing to do with :AirlineThemes You need to install the solarized colorscheme. Then do :colors solarized and possibly also :set bg=dark

djdanielsson commented 7 years ago

screenshot I tried to do exactly what you said after removing all my vimrc information except what was needed for airline and got this, I still think it looks more washed out then your screen shot but maybe that is just me and its actually working. So I'm sorry for wasting your time, thank you for all the work you have done, I love airline.

chrisbra commented 7 years ago

It could be, that the theme has been changed slightly in the past, so the screenshot does not match the theme file anymore. Also, the solarized theme comes with some configuration variables see here Also check the documentation.

However, if you still think some colors need adjustments, feel free to propose some changes. If they are properly documented, I won't refuse to include it.

djdanielsson commented 7 years ago

I took a look at everything again, I think it is probably correct, but for myself I decided to change some colors so it looks more to what I was expecting. Thanks again for all your hard work.