:+1: Add `popup.config` to configure existing popup window

lambdalisue commented 8 months ago

SSIA

Summary by CodeRabbit

New Features
- Introduced a new function to configure window layout for floating and external windows in Neovim.
- Added functionality to override popup options in Vim/Neovim, allowing for customization of position, size, appearance, and behavior.
- Implemented a new configuration function for popups, accommodating different settings based on the host (Vim or Neovim).
Refactor
- Simplified the API by removing specific functions for window and popup configuration.
- Enhanced internal logic for popup and window configuration to ensure consistency and improve usability.
Chores
- Updated internal cache handling for improved performance and reliability.

coderabbitai[bot] commented 8 months ago

Walkthrough

The recent updates streamline the configuration of floating and popup windows in Neovim and Vim. Key changes include the removal of nvim_win_set_config from Neovim's API, simplifying how floating windows are managed. A new function, popup_setoptions, enhances popup customization in Vim, alongside added exports and refinements in popup configuration across both editors. These modifications aim to unify and simplify window management, offering more intuitive and flexible control over UI elements.

Changes

Files	Change Summary
`function/nvim/_generated.ts`	Removed support for reconfiguring floating windows; removed `nvim_win_set_config` function.
`function/nvim/_manual.ts` `function/vim/_manual.ts`	Added exports for `nvim_win_set_config.ts` and `"popup_setoptions.ts"`; re-exported `"prop_add_list.ts"`.
`function/nvim/nvim_win_set_config.ts` `function/vim/popup_setoptions.ts`	Introduced functions for configuring window layout (`nvim_win_set_config`) and overriding popup options (`popup_setoptions`).
`function/vim/_generated.ts`	Removed `popup_setoptions` function from exports.
`popup/...`	Updated popup configuration functions and logic for both Vim and Neovim.

🐇✨
In the land of code and night,
Windows float, popups alight.
Through the changes, swift and bright,
We hop with joy, our screens just right.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 36.92308% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 82.51%. Comparing base (d5d2b1e) to head (00b5bb5).

Files	Patch %	Lines
popup/nvim.ts	40.90%	13 Missing :warning:
popup/mod.ts	21.42%	11 Missing :warning:
popup/vim.ts	56.25%	7 Missing :warning:
function/nvim/nvim_win_set_config.ts	0.00%	5 Missing :warning:
function/vim/popup_setoptions.ts	0.00%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #240 +/- ## ========================================== - Coverage 83.56% 82.51% -1.06% ========================================== Files 55 57 +2 Lines 2903 2962 +59 Branches 262 262 ========================================== + Hits 2426 2444 +18 - Misses 475 516 +41 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vim-denops / deno-denops-std