coderabbitai[bot]
commented
1 month ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The changes involve modifications to several files, primarily focusing on error handling in the parse function, enhancements to buffer decoration functionality, and updates to related test cases. In parse.ts, the error type in the errors array is changed from Error to unknown. The decoration.ts file introduces a new constant and function, updates parameter types for immutability, and modifies existing functions to improve decoration handling. The decoration_test.ts file updates tests to reflect these changes, while deno.jsonc adjusts import entries to enhance configuration.
Changes
| File | Change Summary |
|---|---|
| .scripts/gen-option/parse.ts | Changed err property type from Error to unknown in errors array in parse function. |
| buffer/decoration.ts | Added const prefix, introduced listDecorations function, updated decorate, vimDecorate, and nvimDecorate to use readonly Decoration[]. Modified vimUndecorate logic and updated uniq function. |
| buffer/decoration_test.ts | Updated imports to include listDecorations and undecorate. Refactored collect function and adjusted test cases for vim and nvim. Added tests for listDecorations and undecorate. |
| deno.jsonc | Added new import for @std/collections and reordered import for jsr:@denops/std/eval/stringify. |
Poem
In the burrow, changes sprout,
Error types, we twist about.
Decorations now shine so bright,
With new functions, what a sight!
Hop and skip, let’s celebrate,
For enhancements, we can’t wait! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
SSIA
Summary by CodeRabbit
Release Notes
listDecorationsandundecoratefunctionalities, alongside updates to existing tests for better coverage.