vim-denops / deno-denops-test

🌿 Test helper module for denops.vim

https://jsr.io/@denops/test

MIT License

10 stars 2 forks source link

v1.8.0 breaks the test to check the command line output. #24

Closed Milly closed 4 months ago

Milly commented 4 months ago

16 (included in v1.8.0) breaks the test to check the command line output.

v1.8.0 set verbose=1, which breaks tests that expect verbose=0.

It must be written as a specification or modified.

lambdalisue commented 4 months ago

Plugins usually should work independent from the value of verbose so I don't think we should revert that change (I'd like to say it was just an undefined specification. Not a bug). Documentation should be enough so it won't block #23.

fyi. I noticed denops-std has bug on that, thanks to that change 👍 https://github.com/vim-denops/deno-denops-std/pull/244

Milly commented 4 months ago

Okay, I agree that developers writing tests should be careful.