search

vim-denops / denops.vim

🐜 An ecosystem of Vim/Neovim which allows developers to write cross-platform plugins in Deno
https://vim-denops.github.io/denops-documentation/
MIT License
665 stars 33 forks source link

👍 Remove `Worker` from the system (POC) #291

Closed lambdalisue closed 9 months ago

lambdalisue commented 9 months ago

TBW

Summary by CodeRabbit

coderabbitai[bot] commented 9 months ago

Walkthrough

The changes across various TypeScript files in the codebase reflect a significant refactoring effort. The Host interface and its implementations in Neovim and Vim classes have been updated to enforce stricter parameter types for the batch method. The DenopsImpl class has undergone a structural overhaul, replacing the Session with a new Service instance, which has also been reworked to remove its reliance on Worker and instead use direct method calls on DenopsImpl.

Changes

File Path Change Summary
.../@denops-private/host/base.tsbr>`.../@denops-private/host/nvim.ts`<br.../@denops-private/host/vim.ts Updated batch method signature to accept an array of tuples with stricter typing.
.../@denops-private/impl.ts Removed Session type, introduced Service instance, and reorganized internal structure.
.../@denops-private/service.ts Replaced Worker with DenopsImpl, removed trace parameter, and updated method calls.

🐇✨ In the realm of code, where the rabbits hop, Refactoring's done; the old patterns drop. With tuples aligned, and services anew, The den of Denops shines bright and true. 🌟🎉

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
lambdalisue commented 9 months ago

See https://github.com/vim-denops/denops.vim/pull/293