vim-denops / denops.vim

🐜 An ecosystem of Vim/Neovim which allows developers to write cross-platform plugins in Deno
https://vim-denops.github.io/denops-documentation/
MIT License
685 stars 36 forks source link

💪 Refactoring for denops v6 #292

Closed lambdalisue closed 10 months ago

lambdalisue commented 11 months ago

Make it happen!

Summary by CodeRabbit

coderabbitai[bot] commented 11 months ago

Walkthrough

The changes across the codebase reflect a significant refactoring effort, focusing on simplifying function signatures, updating dependencies, and enhancing type safety. Deprecated functionalities have been removed, and there's a shift towards using promises and type guards. The updates also include performance logging enhancements and a move towards stricter version control in imports.

Changes

File Path Change Summary
autoload/denops/plugin.vim Simplified function signatures for denops#plugin#... functions, removed s:options and s:trace.
denops/@denops-private/cli.ts Updated imports, replaced parse with parseArgs, added ensure and isMeta, and changed logging from console.log to console.warn.
denops/@denops-private/error.ts Updated is function import to a newer version.
denops/@denops-private/host/... Updated imports, modified method signatures and return types, added type guards, and removed deprecated functions.
denops/@denops-private/impl.ts Added ensure and is, introduced isBatchReturn, and modified functions to return promises or direct results.
denops/@denops-private/impl_test.ts Updated dependency versions and added new test step for denops.redraw().
denops/@denops-private/service.ts Updated dependencies, modified constructor and methods to remove deprecated parameters, and introduced disposePlugin.
denops/@denops-private/util.ts Added new module with isMeta predicate function and updated imports.
denops/@denops-private/version.ts Updated path and semver module versions.
denops/@denops-private/worker/script.ts Replaced imports, removed deprecated parameters, added emit function, and updated event listener validation.
doc/denops.txt Removed g:denops#trace, added denops#plugin#discover(), and updated function signatures.
autoload/denops/_internal/server/... Changed s:connect function behavior and added conditional '--quiet' flag in proc.vim.

Poem

🐇✨ In the code's burrow, deep and wide, Refactoring flows like the tide. Simplified calls, types aligned, A rabbit's touch, modernized and refined. 🌟 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging `@coderabbitai` in a comment. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - You can tag `@coderabbitai` in a PR comment and ask questions about the PR and the codebase. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.` - `@coderabbitai read the files in the src/scheduler package and generate README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (886bfa0) 92.59% compared to head (7917a57) 96.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #292 +/- ## ========================================== + Coverage 92.59% 96.42% +3.83% ========================================== Files 3 3 Lines 81 84 +3 Branches 6 5 -1 ========================================== + Hits 75 81 +6 + Misses 6 3 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.