Closed lambdalisue closed 4 months ago
The recent update in the codebase introduces a new type CallbackId
, enhancing type safety by replacing generic string
types for success
and failure
properties within the call
method of the Service
interface. This change is aimed at improving clarity and reducing potential errors related to callback identification.
File Path | Change Summary |
---|---|
denops/.../host.ts |
Introduced CallbackId type; updated call method in Service |
🐰✨ A hop of code, a leap of types,
Strings no more,CallbackId
ignites.
Safer calls in the code's burrow,
A tiny change, a future thorough.
Cheers to the devs, with carrots to bite! 🥕
🌟🐇
denops/@denops-private/host.ts (2)
`48-48`: Introduction of `CallbackId` enhances type specificity and readability. --- `58-59`: Using `CallbackId` for `success` and `failure` properties in `dispatchAsync` method improves semantic clarity and documentation.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.81%. Comparing base (
c727a3f
) to head (37f0c3e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It seems the latest deno fmt try to format the comments like
But the comment was mainly for documentation, so it is better to use type alias instead of comments.
Summary by CodeRabbit