search

vim-denops / denops.vim

🐜 An ecosystem of Vim/Neovim which allows developers to write cross-platform plugins in Deno
https://vim-denops.github.io/denops-documentation/
MIT License
685 stars 36 forks source link

:+1: Automatically wait the target plugin on `denops.dispatch()` #340

Closed lambdalisue closed 5 months ago

lambdalisue commented 5 months ago

Now, denops.dispatch() automatically waits for the target plugin to load, enabling child plugins (e.g., Shougo/ddu-ui-filter for Shougo/ddu) to call the parent plugin's API at any time.

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

The changes bring enhancements to the denops framework, focusing on plugin event management and service improvements. These updates aim to streamline plugin loading processes and provide better monitoring capabilities during runtime.

Changes

File Path Summary of Changes
denops/@denops-private/denops.ts Modified Service type to include waitLoaded, updated DenopsImpl for asynchronous plugin loading
denops/@denops-private/denops_test.ts Added waitLoaded() method, updated test cases for asynchronous loading
denops/@denops-private/service.ts Added plugin load event dispatching methods, introduced #waiters map for managing waiters
denops/@denops-private/service_test.ts Replaced assertThrows with assertRejects in load() method test

🐇✨ In the realm of code, where the bits align, A rabbit hopped through, leaving changes behind. Events now dance, from start to end, In a digital burrow, where scripts befriend. Cheers to the devs, from dusk till dawn, With every commit, a new day is born. 🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.01%. Comparing base (2a39384) to head (897bda7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #340 +/- ## ========================================== + Coverage 89.81% 90.01% +0.20% ========================================== Files 9 9 Lines 648 661 +13 Branches 61 62 +1 ========================================== + Hits 582 595 +13 Misses 66 66 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kuuote commented 5 months ago

dispatch fails if plugin registered and populate dispatcher at mod.main() not completed

test with

test_a/main.ts

import type { Denops } from "https://deno.land/x/denops_std@v6.0.1/mod.ts";

export async function main(denops: Denops) {
  await new Promise((resolve) => setTimeout(resolve, 100));
  await denops.dispatch("test_b", "hello");
}

test_a/main.ts

import type { Denops } from "https://deno.land/x/denops_std@v6.0.1/mod.ts";

export async function main(denops: Denops) {
  await new Promise((resolve) => setTimeout(resolve, 200));
  denops.dispatcher = {
    hello() {
      console.log("hello");
    },
  };
  await denops.dispatch("test_b", "hello");
}
lambdalisue commented 5 months ago

Followed https://github.com/vim-denops/denops.vim/pull/340#discussion_r1596196987, most of code is re-written from scratch so I rebased & force pushed.